conan-center-index icon indicating copy to clipboard operation
conan-center-index copied to clipboard

libpq: add backported OpenSSL 3.2.x fix to libpq/15.5

Open aniederl opened this issue 1 year ago • 9 comments

Summary

Changes to recipe: libpq/15.5

Motivation

Include backported bugfix for using it along with OpenSSL 3.2.x also to version 15.5 issue

Details

The same patch is already applied to 15.3 and 15.4, the update to 15.5 was merged in the same time window as this patch was included, so it was probably missed out.

The patch needed to be rebased to the 15.5 postgres release changing only line numbers and commit hashes. Original author information was left in place.

Upstream includes a fix starting from 15.6 according to the libpq 15.6 release notes

Open PR 21951 should therefore hopefully not be affected by this PR.


aniederl avatar Jun 26 '24 18:06 aniederl

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 26 '24 18:06 CLAassistant

Conan v1 pipeline :x:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Jun 26 '24 19:06 conan-center-bot

Conan v1 pipeline :x:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Jun 26 '24 19:06 conan-center-bot

Conan v1 pipeline :x:

Failure in build 3 (9c30266b6df44644572e5f1440118d6bf852481b):

  • libpq/15.3: Didn't run or was cancelled before finishing

  • libpq/15.5: Didn't run or was cancelled before finishing

  • libpq/13.12: All packages built successfully! (All logs)

  • libpq/15.4: Didn't run or was cancelled before finishing

  • libpq/12.16: Didn't run or was cancelled before finishing

  • libpq/14.9: Didn't run or was cancelled before finishing

  • libpq/11.21: Didn't run or was cancelled before finishing

  • libpq/10.23: An unexpected error happened and has been reported

  • libpq/9.6.24: Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (9c30266b6df44644572e5f1440118d6bf852481b):

  • libpq/15.5: Didn't run or was cancelled before finishing

  • libpq/15.4: Didn't run or was cancelled before finishing

  • libpq/14.9: Didn't run or was cancelled before finishing

  • libpq/13.12: Didn't run or was cancelled before finishing

  • libpq/12.16: Didn't run or was cancelled before finishing

  • libpq/15.3: Didn't run or was cancelled before finishing

  • libpq/9.6.24: Didn't run or was cancelled before finishing

  • libpq/11.21: Didn't run or was cancelled before finishing

  • libpq/10.23: An unexpected error happened and has been reported


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot avatar Jun 27 '24 07:06 conan-center-bot

I'm checking the unexpected error in 10.23, I'll retrigger the CI once I figure it out :)

AbrilRBS avatar Jun 27 '24 08:06 AbrilRBS

Conan v1 pipeline :x:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Jun 28 '24 02:06 conan-center-bot

Conan v1 pipeline :x:

Failure in build 5 (9c30266b6df44644572e5f1440118d6bf852481b):

An unexpected error happened and has been reported. Help is on its way! :horse_racing:


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

conan-center-bot avatar Jul 01 '24 11:07 conan-center-bot

Conan v1 pipeline :x:

Failure in build 6 (9c30266b6df44644572e5f1440118d6bf852481b):

An unexpected error happened and has been reported. Help is on its way! :horse_racing:

conan-center-bot avatar Jul 01 '24 16:07 conan-center-bot

Conan v1 pipeline :heavy_check_mark:

All green in build 7 (9c30266b6df44644572e5f1440118d6bf852481b):

  • libpq/13.12: All packages built successfully! (All logs)

  • libpq/15.4: All packages built successfully! (All logs)

  • libpq/15.5: All packages built successfully! (All logs)

  • libpq/14.9: All packages built successfully! (All logs)

  • libpq/15.3: All packages built successfully! (All logs)

  • libpq/12.16: All packages built successfully! (All logs)

  • libpq/11.21: All packages built successfully! (All logs)

  • libpq/10.23: All packages built successfully! (All logs)

  • libpq/9.6.24: All packages built successfully! (All logs)


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 6 (9c30266b6df44644572e5f1440118d6bf852481b):

An unexpected error happened and has been reported. Help is on its way! :horse_racing:

conan-center-bot avatar Jul 01 '24 18:07 conan-center-bot

Any idea on how I can get more information on these unexpected build errors in the pipeline?

aniederl avatar Jul 23 '24 21:07 aniederl

Conan v1 pipeline :heavy_check_mark:

All green in build 8 (9c30266b6df44644572e5f1440118d6bf852481b):

  • libpq/15.3: All packages built successfully! (All logs)

  • libpq/15.4: All packages built successfully! (All logs)

  • libpq/9.6.24: All packages built successfully! (All logs)

  • libpq/14.9: All packages built successfully! (All logs)

  • libpq/13.12: All packages built successfully! (All logs)

  • libpq/15.5: All packages built successfully! (All logs)

  • libpq/11.21: All packages built successfully! (All logs)

  • libpq/12.16: All packages built successfully! (All logs)

  • libpq/10.23: All packages built successfully! (All logs)


Conan v2 pipeline :heavy_check_mark:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (9c30266b6df44644572e5f1440118d6bf852481b):

  • libpq/15.3: All packages built successfully! (All logs)

  • libpq/15.5: All packages built successfully! (All logs)

  • libpq/15.4: All packages built successfully! (All logs)

  • libpq/14.9: All packages built successfully! (All logs)

  • libpq/12.16: All packages built successfully! (All logs)

  • libpq/10.23: All packages built successfully! (All logs)

  • libpq/13.12: All packages built successfully! (All logs)

  • libpq/11.21: All packages built successfully! (All logs)

  • libpq/9.6.24: All packages built successfully! (All logs)

conan-center-bot avatar Aug 14 '24 10:08 conan-center-bot

This looks good @aniederl but what is the origin of this patch, and does it need to be a different patch (that is, a separate file) than the ones already in use?

I can find https://github.com/postgres/postgres/commit/c82207a548db47623a2bfa2447babdaa630302b9.patch in upstream postgres.

We need this for traceability purposes, otherwise it looks good

jcar87 avatar Aug 14 '24 12:08 jcar87

This looks good @aniederl but what is the origin of this patch, and does it need to be a different patch (that is, a separate file) than the ones already in use?

I can find https://github.com/postgres/postgres/commit/c82207a548db47623a2bfa2447babdaa630302b9.patch in upstream postgres.

We need this for traceability purposes, otherwise it looks good

I actually took the patch with the same name from this repository (within the directory patches/15) which unfortunately did not cleanly apply for 15.5. Since I could not find any parameters to configure the fuzz factor for applying the same patch file onto 15.5 I manually used git apply on a checkout of the postgres 15.5 release tag and redirected the output of git diff into the new patch file.

I can see that this does not look good for traceability. If it makes things easier (and obviously more transparent) I could just use the patch mentioned by you instead.

Just ping me on what you'd prefer to do.

aniederl avatar Aug 14 '24 16:08 aniederl