conan-center-index icon indicating copy to clipboard operation
conan-center-index copied to clipboard

emsdk: add version 3.1.17 and fix 3.1.18 SHA256 due to upstream retagging

Open leha-bot opened this issue 3 years ago • 3 comments

Specify library name and version: emsdk/3.1.17

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

Supersedes #12087.


  • [x] I've read the guidelines for contributing.
  • [x] I've followed the PEP8 style guides for Python code in the recipes.
  • [x] I've used the latest Conan client version.
  • [x] I've tried at least one configuration locally with the conan-center hook activated.

leha-bot avatar Aug 10 '22 12:08 leha-bot

Seems that #12019 introduces the SHA256 error (or upstream retags the release), as I got this error while checking emsdk/3.1.18@:

ERROR: emsdk/3.1.18: Error in source() method, line 29
        tools.get(**self.conan_data["sources"][self.version],
        ConanException: sha256 signature failed for '3.1.18.tar.gz' file.
 Provided signature: 91db2f019b3e33e21099c886845039a9457215e30852ff8dbfc6a874e2a3ef52

 Computed signature: 6479c60710bfb1d146a8bdd8619b693699e73185c850a6eb79ef2bd7e2a8e411

Upstream issue: https://github.com/emscripten-core/emsdk/pull/1083

Will fix it too 👍

leha-bot avatar Aug 10 '22 13:08 leha-bot

All green in build 2 (08c09907dccade10ae374f4e8569a5bc0f2f19ad):

  • emsdk/3.1.17@: All packages built successfully! (All logs)

    :small_orange_diamond: Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • emsdk/3.1.18@: All packages built successfully! (All logs)

    :small_orange_diamond: Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future. This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work. See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12134/recipes/emsdk/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

conan-center-bot avatar Aug 11 '22 01:08 conan-center-bot

Hooks produced the following warnings for commit 08c09907dccade10ae374f4e8569a5bc0f2f19ad
emsdk/3.1.17
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod/BuildSingleReference/.conan/data/emsdk/3.1.17/_/_/package/2880313eadc30db92089af7733fe8364772ee5c8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/.emscripten_cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/tests/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/tests/cmake/target_library/srcfile.cmake
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/Users/jenkins/w/prod/BuildSingleReference/.conan/data/emsdk/3.1.17/_/_/package/cf186363a0bf37e3a91ee26c25ea5d664ac71fa5/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/Users/jenkins/w/prod/BuildSingleReference/.conan/data/emsdk/3.1.17/_/_/package/b5f241903b556300ec582ac54016b40dc81591fd/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/tests/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/tests/cmake/target_library/srcfile.cmake
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] objdump not found
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@3/s/0923e2/1/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/.emscripten_cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/tests/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/tests/cmake/target_library/srcfile.cmake
emsdk/3.1.18
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod/BuildSingleReference/.conan/data/emsdk/3.1.18/_/_/package/2880313eadc30db92089af7733fe8364772ee5c8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/.emscripten_cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/test/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/test/cmake/target_library/srcfile.cmake
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/Users/jenkins/w/prod/BuildSingleReference@2/.conan/data/emsdk/3.1.18/_/_/package/cf186363a0bf37e3a91ee26c25ea5d664ac71fa5/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/Users/jenkins/w/prod/BuildSingleReference@3/.conan/data/emsdk/3.1.18/_/_/package/b5f241903b556300ec582ac54016b40dc81591fd/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/test/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/test/cmake/target_library/srcfile.cmake
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] objdump not found
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@2/s/d36b78/1/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./bin/.emscripten_cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cache/sysroot/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/cmake/Modules/CMakeSystemSpecificInformation.cmake; ./bin/upstream/emscripten/cmake/Modules/CheckTypeSize.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenAL.cmake; ./bin/upstream/emscripten/cmake/Modules/FindOpenGL.cmake; ./bin/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake; ./bin/upstream/emscripten/cmake/Modules/TestBigEndian.cmake; ./bin/upstream/emscripten/system/lib/cmake/SDL2/sdl2-config.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleCompilerRT.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/Modules/HandleLibunwindFlags.cmake; ./bin/upstream/emscripten/system/lib/libunwind/cmake/config-ix.cmake; ./bin/upstream/emscripten/test/cmake/install_lib/FooConfig.cmake; ./bin/upstream/emscripten/test/cmake/target_library/srcfile.cmake

github-actions[bot] avatar Aug 11 '22 01:08 github-actions[bot]

Why is the bot not merging this one automatically?

prince-chrismc avatar Aug 15 '22 15:08 prince-chrismc

Why is the bot not merging this one automatically?

Good question (given the label), but:

  • library logic merges automatically only if the Bump deps/ver label is the unique one (not sure if it is a bug or a feature, wdyt, @uilianries ?)
  • [bug] Given that it is modifying a sha256 key too, it shouldn't be considered a bump-deps/ver, moreover now that we agreed on paying special care to these checksum changes

jgsogo avatar Aug 16 '22 07:08 jgsogo

library logic merges automatically only if the Bump deps/ver label is the unique one (not sure if it is a bug or a feature, wdyt, @uilianries ?)

Right. I prefer "a conservative feature". As we can't prevent all crazy cases, I still prefer to analyze those which are not regular.

uilianries avatar Aug 16 '22 13:08 uilianries