cmake-conan icon indicating copy to clipboard operation
cmake-conan copied to clipboard

Update conan.cmake to support actual version of Visual Studio 2022

Open giovaorama opened this issue 1 year ago • 2 comments

As reported in https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html the maximum value for the visual studio 2022 is now less than 1950 not 1940. 1940 is the release 17.10

giovaorama avatar Aug 22 '24 10:08 giovaorama

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 22 '24 10:08 CLAassistant

Hi @giovaorama

Thanks for your contribution. This has already been fixed and merged to develop branch in https://github.com/conan-io/cmake-conan/pull/643, marking this as a duplicate.

A release hasn't been done, because cmake-conan for 1.X is now legacy, the default and maintained one is Conan 2 using the new CMake dependency providers.

memsharded avatar Aug 22 '24 10:08 memsharded