cmake-conan icon indicating copy to clipboard operation
cmake-conan copied to clipboard

Published 20 hours ago • verified publisher icon conan-io

Restore detection of target OS

Open saierd opened this issue 3 years ago • 1 comments

This was broken in 61ae3b3356f2f2c6ca2a3dd0fedcc21a407bbe1c. The variable is getting set correctly, but it was never added to the actual settings.

saierd avatar May 06 '22 14:05 saierd

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 06 '22 14:05 CLAassistant

@czoido I just had the same issue, not getting the os from conan_cmake_autodetect - the workaround is easy but it would be great if this PR could be merged. Thanks in advance.

tk-tnz avatar Sep 28 '23 22:09 tk-tnz

@czoido I just had the same issue, not getting the os from conan_cmake_autodetect - the workaround is easy but it would be great if this PR could be merged. Thanks in advance.

Hi @tk-tnz,

Thanks for the ping and sorry for the late response. We are focusing our efforts in the develop2 branch that's compatible with Conan 2.0 and has a much consistent approach using CMake's dependency providers. Pleas, have a look if you want to continue using cmake-conan with newer Conan versions.

Anyway, I have added a test for this and personally think that it could be merged to consider cases that do not have the os defined in the default profile (as a temporary workaround you may define it there and it should work). I would be ok merging this but I'm assigning @memsharded this one so he can take the final decision in case there's something I'm missing.

czoido avatar Sep 29 '23 10:09 czoido

We would need @saierd re-signing the CLA, there were some changes some time ago that requires re-signing. Could you please check that @saierd?

memsharded avatar Sep 29 '23 22:09 memsharded

Thanks for the ping and sorry for the late response. We are focusing our efforts in the develop2 branch that's compatible with Conan 2.0 and has a much consistent approach using CMake's dependency providers. Pleas, have a look if you want to continue using cmake-conan with newer Conan versions.

Thanks for your prompt replies! Yes, I looked at the develop2 branch but haven't had the time to look at how feasible it will be to migrate my existing setup (which is not the most trivial with conan being automatically invoked by cmake a number of times with dynamically generated profiles from cmake in different subdirectories).

tk-tnz avatar Sep 29 '23 23:09 tk-tnz

We would need @saierd re-signing the CLA, there were some changes some time ago that requires re-signing. Could you please check that @saierd?

I have signed the CLA again.

saierd avatar Sep 30 '23 07:09 saierd