cmake-conan icon indicating copy to clipboard operation
cmake-conan copied to clipboard

Remove wrong include and modernize example

Open stephan-cr opened this issue 4 years ago • 3 comments
trafficstars

stephan-cr avatar Mar 22 '21 23:03 stephan-cr

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 22 '21 23:03 CLAassistant

Hi @stephan-cr, Thanks a lot for the contribution. The duplicated include is ok, it is supposed to include the downloaded conan.cmake in case someone uncomments that block of code. If we remove it it will take the file in the root folder instead of the downloaded one. Also, the cmake_minimum_required should be raised to 3.8 when cxx_std_11 was introduced.

czoido avatar Mar 23 '21 18:03 czoido

@czoido Resolved the merge conflict.

I would also propose to include conan.cmake like include(conan), because I think that's the point of having list(APPEND CMAKE_MODULE_PATH ${CMAKE_BINARY_DIR}) at the top.

stephan-cr avatar Apr 14 '21 09:04 stephan-cr