compound-protocol icon indicating copy to clipboard operation
compound-protocol copied to clipboard

Add in-queue check for cancelTransaction() in Timelock.sol

Open AmazingAng opened this issue 3 years ago • 2 comments
trafficstars

Add in-queue check for cancelTransaction() in Timelock.sol :

        require(queuedTransactions[txHash], "Timelock::cancelTransaction: Transaction hasn't been queued.");

before deleting the transaction from the queue:

        queuedTransactions[txHash] = false;

Link to #214

AmazingAng avatar Aug 12 '22 08:08 AmazingAng

  1. Delete import SafeMath, since SafeMath is no longer needed starting with Solidity 0.8.
  2. Delete keyword "public" in constructor

AmazingAng avatar Aug 12 '22 14:08 AmazingAng

Add in-queue check for cancelTransaction() in Timelock.sol :

        require(queuedTransactions[txHash], "Timelock::cancelTransaction: Transaction hasn't been queued.");

before deleting the transaction from the queue:

        queuedTransactions[txHash] = false;

Link to #214

Setland34 avatar Jun 19 '23 01:06 Setland34