compound-js icon indicating copy to clipboard operation
compound-js copied to clipboard

gasLimit seems not considered properly

Open michael-spengler opened this issue 4 years ago • 2 comments

Hi compound-js team.

I'm very happy about your library and so far everything worked as documented and expected. One thing seems unclear to me:

I triggered a supply transaction with a gasLimit set to 250000 - however the gas price paid according to etherscan.io... was higher than 250000 GWEI --> 0.00025 Ether (if I understood things correctly):

        const trxOptions = { gasLimit, mantissa: false }

        try {
            const trx = await compound.supply(Compound.ETH, amountOfEtherToBeDeposited, trxOptions)
            console.log(`You can check the deposit to compound transaction at https://etherscan.io/tx/${trx.hash}`)
        } catch (error) {
            console.log(`Something went wrong while depositing Ether to compound.finance: ${error.message}`)
        }

So my inquiry is: Is it possible that the gasLimit is not taken into consideration properly by the implementation?

michael-spengler avatar Jan 15 '21 23:01 michael-spengler

Hmm.. This parameter is passed into the Ethers.js transaction. I can look at your transaction hash on etherscan if you'd like. Feel free to DM me in Discord.

ajb413 avatar Jan 15 '21 23:01 ajb413

@ajb413 Hi Adam. Thank you. I just posted the inquiry in the support-help channel in order to find out your discord handle: https://discord.com/channels/402910780124561410/765610989847969810/799916325756993536

:)

michael-spengler avatar Jan 16 '21 08:01 michael-spengler