compas icon indicating copy to clipboard operation
compas copied to clipboard

new functions for compas geometry

Open nikeftekhar opened this issue 5 years ago • 8 comments

new functions regarding the following topics: line divide by count polyline shorten polyline rebuild polyline divide by count polyline tween transformations extend line transformations extend polyline intersection_mesh_line intersection_mesh_plane split polyline_plane split mesh_plane

What type of change is this?

  • [ ] Bug fix in a backwards-compatible manner.
  • [x] New feature in a backwards-compatible manner.
  • [ ] Breaking change: bug fix or new feature that involve incompatible API changes.
  • [ ] Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • [x] I ran all tests on my computer and it's all green (i.e. invoke test).
  • [x] I ran lint on my computer and there are no errors (i.e. invoke lint).
  • [x] I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added necessary documentation (if appropriate)

nikeftekhar avatar Jun 24 '20 11:06 nikeftekhar

Hi everyone,

First, thank you for the great package. Would it be possible to know when this will be merged. I need the function intersection_mesh_line for one of my experiment.

All the best

nperraud avatar Oct 01 '20 06:10 nperraud

hi, it seems there are still quite a bit of unaddressed comments. if you resolve those, i am more than happy to merge immediately. if in the meantime you need mesh/line intersections urgently you could use intersection_mesh_ray of compas_libigl...

tomvanmele avatar Oct 01 '20 06:10 tomvanmele

also, in the case of intersection_mesh_plane you could use the slicing functionality of compas_cgal, if you need it urgently...

tomvanmele avatar Oct 01 '20 07:10 tomvanmele

@tomvanmele this is meaningful work, but this has been sitting here for a long time... Since the author hasn't responded to the excellent code review, I think its fair to close it.

jf--- avatar Apr 16 '24 12:04 jf---

Hi I am the author,

This commits were result of the work I was doing at mesh 4 years ago. Due to covid, funds of mesh got shortened and I could not continue the project. Now im doing a phd at DBT, and I would be delighted to finalise those commits and comments if you really think are a good contribution, but I have completely lost the environment and the code and everything.

If you were so kind, we could set a meeting, may be you could guide me through on how to set the working environment and everything properly and I will be delighted to finish the contribution applying all the comments that were done 4 years ago.

Best,

Nik Eftekhar Olivo

El 16.04.2024, a las 14:47, Jelle Feringa @.***> escribió:

@tomvanmelehttps://github.com/tomvanmele this is meaningful work, but this has been sitting here for a long time... Since the author hasn't responded to the excellent code review, I think its fair to close it.

— Reply to this email directly, view it on GitHubhttps://github.com/compas-dev/compas/pull/569#issuecomment-2059011472, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKK6EFS5JR3RF66EZEAS2F3Y5UMX7AVCNFSM4OGSN3MKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBVHEYDCMJUG4ZA. You are receiving this because you authored the thread.Message ID: @.***>

nikeftekhar avatar Apr 16 '24 13:04 nikeftekhar

we could set a meeting, may be you could guide me through on how to set the working environment and everything properly

@nikeftekhar yep, let's do that, feel free to poke me directly in person, or send me a calendar invite to do this

gonzalocasas avatar Apr 16 '24 15:04 gonzalocasas

Hi Gonzalo,

Perfect then ill try to approach you during this week or the following

Best,

Nik

El 16.04.2024, a las 17:53, Gonzalo Casas @.***> escribió:

we could set a meeting, may be you could guide me through on how to set the working environment and everything properly

@nikeftekharhttps://github.com/nikeftekhar yep, let's do that, feel free to poke me directly in person, or send me a calendar invite to do this

— Reply to this email directly, view it on GitHubhttps://github.com/compas-dev/compas/pull/569#issuecomment-2059421266, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKK6EFUXTA47DJOKGMJJMG3Y5VCQXAVCNFSM4OGSN3MKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBVHE2DEMJSGY3A. You are receiving this because you were mentioned.Message ID: @.***>

nikeftekhar avatar Apr 16 '24 16:04 nikeftekhar