add-to-calendar-buttons icon indicating copy to clipboard operation
add-to-calendar-buttons copied to clipboard

Published 20 hours ago • verified publisher icon commonpike

Method 2 bug in office 365 params

Open joepagan opened this issue 5 years ago • 2 comments

Wrapping short hand conditional in brackets otherwise will result in &location=true

'&location=' + (event.address || ''),
'&allday=' + (event.allday)?'true':'false'

will result in &location=,true which later turns into &location=true

wrapping the allday shorthand conditional in brackets returns it correctly as: &location=&allday=true

joepagan avatar Sep 16 '20 08:09 joepagan

all nice work joe, thanks ! - I have no time to test & merge it now, but it all looks good, keep it up !

commonpike avatar Sep 16 '20 08:09 commonpike

Thanks, no problem & no pressure as using a local version that I've manipulated on a project I've been looking at and this isn't under a package manager (That I know of?)

just FYI, I haven't re-built the minified file on this & the other PR, not sure how you are handling that so didn't want to touch until I knew

joepagan avatar Sep 17 '20 13:09 joepagan