WIP handle state variables in js comments

[ionox0]

I haven't tested this, but just wanted to gauge interest in support for some of these STATE variables within comments in the expression tools.

I had a situation like this:

${
  // this comment's got a quote in it!
  var asdf = ...
...

Which caused:

Substitution error, unfinished block starting at position 0: ${

I believe because of the quote in the comment. Can add a test or refactor if interested

[cwl-bot]

Can one of the admins verify this patch?

[codecov[bot]]

Codecov Report

Merging #739 (05fc01b) into main (a1e3449) will decrease coverage by 0.06%. The diff coverage is n/a.

:exclamation: Current head 05fc01b differs from pull request most recent head 1f3e813. Consider uploading reports for the commit 1f3e813 to get more accurate results

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   65.90%   65.84%   -0.07%     
==========================================
  Files          93       89       -4     
  Lines       16447    15624     -823     
  Branches     4358     3935     -423     
==========================================
- Hits        10840    10287     -553     
+ Misses       4455     4249     -206     
+ Partials     1152     1088      -64     

Impacted Files	Coverage Δ
cwltool/sandboxjs.py	65.68% <0.00%> (-8.92%)	:arrow_down:
cwltool/main.py	62.00% <0.00%> (-4.98%)	:arrow_down:
cwltool/checker.py	77.65% <0.00%> (-4.40%)	:arrow_down:
cwltool/argparser.py	85.97% <0.00%> (-3.81%)	:arrow_down:
cwltool/task_queue.py	73.33% <0.00%> (-3.72%)	:arrow_down:
cwltool/builder.py	68.23% <0.00%> (-3.11%)	:arrow_down:
checker.py	85.10% <0.00%> (-2.93%)	:arrow_down:
cwltool/executors.py	81.77% <0.00%> (-1.56%)	:arrow_down:
cwltool/pack.py	86.59% <0.00%> (-1.41%)	:arrow_down:
executors.py	64.00% <0.00%> (-1.32%)	:arrow_down:
... and 51 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1e3449...1f3e813. Read the comment docs.

[mr-c]

Jenkins, okay to test

[ionox0]

I do see this bit here down in interpolate, so not sure if I'm seeing the full picture on this one:

        elif scan[w[0]] == '\\':
            e = scan[w[1] - 1]
            parts.append(e)

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 1eda8337658ea357ec0ee274ebdf0035058155d5 into 84939620c3eec1ab11369849c63237ebfa48da41 - view on LGTM.com

new alerts:

• 2 for Unnecessary pass

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 8de89c45b088ec5f6ee474c2390dbf8ca05aa326 into 05fc01bd00251217a219faaf63b9947d200eb849 - view on LGTM.com

new alerts:

• 2 for Unnecessary pass

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging a2876e0bfc3fb6dbe74991b72587c3ad879fbea6 into 05fc01bd00251217a219faaf63b9947d200eb849 - view on LGTM.com

new alerts:

• 2 for Unnecessary pass

[lgtm-com[bot]]

This pull request introduces 2 alerts when merging 1f3e8138a7dc6d5e5dc00ed4df5067378fc97979 into a1e3449560b964d90818b2f1bfeb9b411415a786 - view on LGTM.com

new alerts:

• 2 for Unnecessary pass