cz-conventional-changelog icon indicating copy to clipboard operation
cz-conventional-changelog copied to clipboard

fix(engine.ts): Fix typo in subject prompt

Open Infiltrator opened this issue 7 years ago • 6 comments

Hopefully you are nice and relaxed when writing your commit messages.

Infiltrator avatar Oct 19 '18 05:10 Infiltrator

Dupe of #72? 😄

LinusU avatar Oct 19 '18 07:10 LinusU

Ah, I see what you are trying to say now. The problem is that "short" is an adjective, which applies to "description", but "tense" is a noun, to which "imperative" applies as an adjective, so to make it grammatically correct, it should be "short, imperatively tensed description", with "tense" becoming a past participle (effectively making it an adjective) for "description", and "imperative" becoming an adverb describing "imperatively".

Having said that, "Write a short, imperatively tensed description of the change:" might sound funny to some people, so some other ways are:

  • "Write a short description of the change in the imperative tense:"
  • "Write a short description of the change (use the imperative tense):"
  • "Using the imperative tense, write a short description of the change:"

Or, if only one other person and I have found this a problem and everybody else understands what you are trying to say, then you can leave it be.

Infiltrator avatar Oct 21 '18 21:10 Infiltrator

I'd be happy with an update to the text, especially since this keeps coming up ☺️

ping @commitizen/admins

LinusU avatar Oct 24 '18 09:10 LinusU

Sure thing. Any preferences for phrasing? Personally, I like "Write a short, imperatively tensed description of the change", but I know that might sound arcane to some people. I like the second of the three alternatives, because the parentheses draw the reader's attention, and it is another imperative phrase, which will make people more likely to follow it.

Infiltrator avatar Oct 24 '18 15:10 Infiltrator

Oh, and as pointed out in #71, it should be "mood", not "tense", as grammatical tense is only about time. It kept feeling very strange to me every time that I read or wrote it but could not quite put my finger on it. I will change that at the same time in the PR.

Infiltrator avatar Oct 24 '18 16:10 Infiltrator

If you change this to mood I'll merge it.

jimthedev avatar Jul 19 '19 20:07 jimthedev