sphere-scala-libs icon indicating copy to clipboard operation
sphere-scala-libs copied to clipboard

Published 20 hours ago • verified publisher icon commercetools

Remove BigDecimal from HighPrecisionMoney.fromPreciseAmount

Open benko-balog opened this issue 3 years ago • 2 comments

Added 3 rounding algorithms to substitute the methods used on BigDecimal

benko-balog avatar Oct 13 '22 12:10 benko-balog

For now, we are keeping this PR without merging to see if the previous changes were enough to improve the performance. We are checking if there are more tests we could add, to make sure roundings are working correctly.

benko-balog avatar Oct 18 '22 15:10 benko-balog

@benko-balog Should we just close this for now and re-open if ever needed?

clemniem avatar Jan 18 '23 12:01 clemniem