openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

HKG: Car Port for Genesis GV70 2022 (3.5T, HDA2)

Open sunnyhaibin opened this issue 1 year ago • 2 comments

Checklist

  • [x] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot:
    • f1b6af6fdf6c0a78: f1b6af6fdf6c0a78/00000004--5a6db3a9bd
    • d81673ef19d79a4e:
  • [x] route with stock system: afe09b9f5d3f3548/00000005--fe8cd35e57
  • [x] car harness used (if comma doesn't sell it, put N/A): N/A (See below)
    • Modified Harness M: https://github.com/commaai/openpilot/issues/30645

Thanks to the community 2022 Genesis GV70 3.5T owners taylababygirl (Discord) and animatronichobbes.

sunnyhaibin avatar Mar 05 '24 04:03 sunnyhaibin

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 05 '24 04:03 github-actions[bot]

Working route: f1b6af6fdf6c0a78/00000004--5a6db3a9bd

sunnyhaibin avatar Apr 11 '24 06:04 sunnyhaibin

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

sshane avatar Aug 20 '24 06:08 sshane