openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

CI: MetaDrive in ga

Open maxime-desroches opened this issue 1 year ago • 6 comments

For https://github.com/commaai/openpilot/issues/30693

Succeed 10 times in a row, will do more testing.

maxime-desroches avatar Dec 17 '23 10:12 maxime-desroches

Nice! It engaged but I'm curious about the FPS from the sim. We can disable the UI since that will take quite a bit of CPU to software render.

selfdrive/ui/qt/onroad.cc: slow frame rate: 5.79 fps

jnewb1 avatar Dec 17 '23 16:12 jnewb1

@jnewb1 Yeah, seems run better with the ui blocked

maxime-desroches avatar Dec 17 '23 18:12 maxime-desroches

The idea is to replicate the test_onroad coverage both in GitHub Actions and in the simulator, so we don't want to start turning things off. Can we make the UI run nicely during the test? Is that the only thing that lags here?

adeebshihadeh avatar Dec 17 '23 18:12 adeebshihadeh

@adeebshihadeh From my tests it seem to only be the ui lagging and soundd crashing. Do we want the ui running above 15 fps?

maxime-desroches avatar Dec 18 '23 03:12 maxime-desroches

Yes, we want to run the full stack. Does soundd crash consistently or intermittently?

adeebshihadeh avatar Dec 18 '23 03:12 adeebshihadeh

soundd is crashing because there is no sound device to connect to, we will just have to add a virtual sound card or something

jnewb1 avatar Dec 18 '23 03:12 jnewb1

Closing due to no activity, feel free to reopen if you pick it back up.

adeebshihadeh avatar Jan 19 '24 23:01 adeebshihadeh

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

github-actions[bot] avatar Jan 23 '24 17:01 github-actions[bot]