ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Silversith Main Branch

Open SilverAndJade opened this issue 2 years ago • 5 comments

@comfyanonymous I don't expect you to merge this in, but I just thought I'd ask your opinion 😊

SilverAndJade avatar Apr 07 '23 16:04 SilverAndJade

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

comfyanonymous avatar Apr 08 '23 07:04 comfyanonymous

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

SilverAndJade avatar Apr 08 '23 07:04 SilverAndJade

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

Actually maybe I can disable the load from output if there's more than 50 images and only load for the session. That would stop the refresh load though, but maybe that's a better solution.

SilverAndJade avatar Apr 08 '23 07:04 SilverAndJade

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

Actually maybe I can disable the load from output if there's more than 50 images and only load for the session. That would stop the refresh load though, but maybe that's a better solution.

@comfyanonymous I made some quick changes that I also only very quickly tested. It won't load the images form the output folder if there's more than 50 and will also then disable the delete all button

SilverAndJade avatar Apr 08 '23 08:04 SilverAndJade

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

I gave this a try and unfortunately it crashed my browser probably because I have over 10k images in the output folder.

😅 I didn't think of that. I guess I'll have to cap the images to 100 thumbnails... Maybe less depending on the size of the images. 50 maybe?

Actually maybe I can disable the load from output if there's more than 50 images and only load for the session. That would stop the refresh load though, but maybe that's a better solution.

@comfyanonymous I made some quick changes that I also only very quickly tested. It won't load the images form the output folder if there's more than 50 and will also then disable the delete all button

I'm considering changing the delete all (which deletes everything from the output folder) to only delete images that are displayed in the list

SilverAndJade avatar Apr 08 '23 08:04 SilverAndJade

(Don't mind me, just cleaning up the PR backlog, and noticed this was I don't expect you to merge this in)

mcmonkey4eva avatar Aug 14 '23 21:08 mcmonkey4eva