ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Ability to switch between different graphs

Open JAlB- opened this issue 2 years ago • 29 comments

image

JAlB- avatar Mar 28 '23 21:03 JAlB-

Wow. Nice work!

ltdrdata avatar Mar 28 '23 21:03 ltdrdata

What I meant is that I would like the workflows to be in a folder like: workflows/default_txt2img.json workflows/area_composition.json in the same format you get when you export them from the UI.

This is so I can easily modify them if I change things.

comfyanonymous avatar Mar 28 '23 21:03 comfyanonymous

What I meant is that I would like the workflows to be in a folder like: workflows/default_txt2img.json workflows/area_composition.json in the same format you get when you export them from the UI.

This is so I can easily modify them if I change things.

Can we implement this later? I just have some more ideas that I would like to implement to make using ComfyUI more convenient.

JAlB- avatar Mar 28 '23 22:03 JAlB-

is it that difficult to implement? You can just put a list of filenames in the code and fetch them.

comfyanonymous avatar Mar 28 '23 22:03 comfyanonymous

image It's not that difficult, you can just download it and fix everything you want at once and save it. Thus, you can store an arbitrary number of presets without changing the code at all. To make such functionality with separate files, you will also have to write code in the server part that will give a list of files.

JAlB- avatar Mar 28 '23 22:03 JAlB-

I only mean for the presets that are already there.

comfyanonymous avatar Mar 28 '23 22:03 comfyanonymous

The: web/DefaultWorkflows.json should be multiple files like: workflows/default_txt2img.json workflows/area_composition.json

comfyanonymous avatar Mar 28 '23 22:03 comfyanonymous

The: web/DefaultWorkflows.json should be multiple files like: workflows/default_txt2img.json workflows/area_composition.json

Do you think it makes sense to do this for presets that are loaded only once at the first launch? Then it's all not used anywhere.

JAlB- avatar Mar 28 '23 22:03 JAlB-

yes because those presets will likely be modified a lot by me and others so I want it to be simple.

comfyanonymous avatar Mar 28 '23 22:03 comfyanonymous

Then I will make an index file.json that will contain a list of files with presets. So will it be normal?

JAlB- avatar Mar 28 '23 22:03 JAlB-

yes that's good.

comfyanonymous avatar Mar 28 '23 22:03 comfyanonymous

To implement sequential downloading of several files so that nothing breaks quickly does not work, while I leave it like this. Either generate it on the server side or come up with a loading method that takes into account the asynchrony of requests. I'll probably do it tomorrow.

JAlB- avatar Mar 29 '23 00:03 JAlB-

This is awesome. Could use some Styling, like darker shade than graph BG but not black against white which is terrible for eyes and not advised for dark themes. Buttons could use BGs.

High contrast is more a accessibility theme for people receiving less light in their eyes, for a lot of other people it causes headaches, ghosting of lettering against blackness, etc.

WASasquatch avatar Mar 29 '23 00:03 WASasquatch

I did the loading of default graphs from several files.

JAlB- avatar Mar 29 '23 21:03 JAlB-

I like this addition! Would be great if it could be toggleable, maybe on the side menu that is already there! 2023-03-30_10-40-15

FraYoshi avatar Mar 30 '23 08:03 FraYoshi

I plan to move the side menu to the top menu. It's just not such an important task to do it now. Now I want to make an additional interface to interact with the nodes and a graphical editor.

JAlB- avatar Mar 30 '23 09:03 JAlB-

Oh no, you got there first :smile: . I was also working on GUI to add libraries, history and multiple graphs. The main issue is that litegraph.js has few bugs :/. image

KaruroChori avatar Mar 30 '23 13:03 KaruroChori

that will be great

omar92 avatar Apr 03 '23 19:04 omar92

any updates on this ??

omar92 avatar Apr 06 '23 12:04 omar92

any updates on this ??

If you want it merged faster you should test it and let us know if you find any bugs or if everything works fine.

comfyanonymous avatar Apr 06 '23 14:04 comfyanonymous

any updates on this ??

I'm still working on additional functionality

JAlB- avatar Apr 06 '23 15:04 JAlB-

any updates on this ??

If you want it merged faster you should test it and let us know if you find any bugs or if everything works fine.

ok sure , thanks for the hard work

omar92 avatar Apr 07 '23 20:04 omar92

im kinda new in that stuff , shall i clone the whole repo again , or there are a way to only see the changes

i added [email protected]:JAlB-/ComfyUI.git as another remote source i fetched it but when i run i cant see the new ui

omar92 avatar Apr 07 '23 20:04 omar92

oh sorry had to clear the browser cache

omar92 avatar Apr 07 '23 20:04 omar92

I'm going to die waiting for this.

ltdrdata avatar Apr 19 '23 07:04 ltdrdata

Been driving this, must have feature or something akin to it. Brings this closer to the usability / friendliness of A1111 by being able to rapidly switch through workflows without manually managing save files.

Hawox avatar Apr 29 '23 14:04 Hawox

Unfortunately, I can't devote as much time to the project as I would like. If there is a desire to help, then I will not refuse to help.

JAlB- avatar Apr 29 '23 14:04 JAlB-

@JAlB- what features are missing in this currently? Are there any bugs your already aware of?

M1kep avatar Jul 14 '23 17:07 M1kep

This is really old and likely not even compatible with a merge to test without manually fixing things.

WASasquatch avatar Jul 14 '23 17:07 WASasquatch