Hyeseong Kim

Results 389 comments of Hyeseong Kim

ReScript's JS codebase is now fully ESM. If anyone needs exceptions, specify the extension as `.cjs` or place a `{ "type": "commonjs" }` in the submodule `package.json` file. Fortunately, ReScript...

Anyone who frequently accesses js codebases is welcome, maybe @DZakh ?

Yes, it was an error, but I turned it into a warning to stop the refactoring here. I'll fully rewrite that part in another PR

> It would be nice to get by without introducing a new top-level folder lib_dev just for those three files. I must confess that I didn't really have a good...

> Probably another nit pick: got this diff as well after running `make test`: @nojaf I think this is caused by https://github.com/rescript-lang/rescript/commit/2fb6cc8015bbeb902f8bb8f2b6273bc70ecf787f What's the version of Node.js you're using?

> v22.13.1 Yep, you should downgrade then. see the `.nvmrc`. I'm using [mise](https://mise.jdx.dev/) for that

Thanks, updated the ignore file

I missed here.. What are the use cases of the equality check for Error objects and its messages? Can you add some examples or tests here? I see... so this...

Good catch. This is unintended. I think it is more like a design-space issue, not an implementation bug The addition of `as any` assumes that it is already fully verified...