certbot-dns-netcup icon indicating copy to clipboard operation
certbot-dns-netcup copied to clipboard

for a good friend of mine

Open andybe opened this issue 3 years ago • 1 comments
trafficstars

  • this friend of mine runs the container weekly and the container must not be destroyed always, but for a good reason sometimes
  • we combine this with a service that not include certbot
  • docker-compose easy to use without extra shell in cron job.
  • only change variables and you on the go,- there people out there who find that many commands to docker to much (not me)
  • put ENV into .env for sure it's up to the users

It's written to hold it simple as possible

andybe avatar Jun 16 '22 10:06 andybe

Hey,

ok thanks.

Can you also add a short mention in the README.rst and how to use it about this example?

I have some more remarks:

  • use a default for NETCUP_SECONDS when it's not specified by the user e.g. by passing ${NETCUP_SECONDS:-900} to certbot
  • certbot should be called as CMD not ENTRYPOINT
  • it would actually be nice to declare all variables up-front in the Dockerfile and error-handle their non-existence in the entrypoint.sh but this may be a bit too finicky for this simple example, it's your choice.

coldfix avatar Jun 17 '22 08:06 coldfix