next-wordpress-starter icon indicating copy to clipboard operation
next-wordpress-starter copied to clipboard

Microformat

Open colbyfayock opened this issue 5 years ago • 24 comments

We should add logical microformats throughout the site

http://microformats.org/ https://microformats.io/ https://developer.mozilla.org/en-US/docs/Web/HTML/microformats

colbyfayock avatar Oct 15 '20 02:10 colbyfayock

which part to add microformat?

arifsetyo21 avatar Oct 17 '20 17:10 arifsetyo21

hey @arifsetyo21 i'm hoping to add as much coverage as makes sense, so that includes author information, post information, website information. it would be great if as part of this issue, the person who takes it tries to figure out what all make sense

colbyfayock avatar Oct 17 '20 18:10 colbyfayock

Okay, can i do this issue?

arifsetyo21 avatar Oct 17 '20 19:10 arifsetyo21

sure thing :) let me know if you have any issues!

colbyfayock avatar Oct 18 '20 00:10 colbyfayock

I don't know if this belongs in this issue but it would be good to have everything required for webmentions leveraging of microformats in here.

doingandlearning avatar Oct 24 '20 08:10 doingandlearning

(I'll find a link!)

doingandlearning avatar Oct 24 '20 08:10 doingandlearning

yes! that was one of the things i had in mind when thinking about it. it would be cool as that information is valuable for services that can provide a rich experience and if im not mistaken even search engines use it

colbyfayock avatar Oct 24 '20 12:10 colbyfayock

hey @arifsetyo21 checking in - are you having any luck with this?

colbyfayock avatar Oct 25 '20 13:10 colbyfayock

unassigning this to allow someone else to work on it

colbyfayock avatar Oct 27 '20 22:10 colbyfayock

@colbyfayock I'll take this up if no one else is working on it. Also, I think this issue should be split in two as there could be too many changes at once.

Azanul avatar Oct 04 '22 10:10 Azanul

@Azanul sounds good to me! would love to hear your thoughts then before moving forward including the work that needs to be done and what you see as the 2 issues

colbyfayock avatar Oct 04 '22 10:10 colbyfayock

@colbyfayock I meant 2 PRs as there can be many changes.

Azanul avatar Oct 09 '22 15:10 Azanul

Got it, I would still like 2 issues to have concise details around the problems each are solving so that we're not creating 2 PRs for the sake of creating 2 PRs

colbyfayock avatar Oct 09 '22 15:10 colbyfayock

@colbyfayock I've read about microformats now. What I understood is we'll have to add appropriate class names to all components, right?

Azanul avatar Oct 14 '22 15:10 Azanul

from what i understand i think thats part of it. i was also under the impression there would be more attributes than classes, such as "roles" and such, but i haven't looked too deeply into it

colbyfayock avatar Oct 14 '22 16:10 colbyfayock

You mean adding rel attribute? https://developer.mozilla.org/en-US/docs/Web/HTML/microformats#microformats_rel_property_examples

Azanul avatar Oct 14 '22 17:10 Azanul

yeah haha that might be it! :D

i trust whatever you find out through your research

colbyfayock avatar Oct 14 '22 17:10 colbyfayock

Let's divide it in either of these two ways:

  1. per component
  2. all components per required task (i.e., rel attribute and class name)

Azanul avatar Oct 14 '22 17:10 Azanul

i don't think it makes sense to create a new PR for every component, but if you'd like to break up the work another way, such as one for pages and one for components, I'm open to that

colbyfayock avatar Oct 14 '22 17:10 colbyfayock

Not one PR for each component but one for half of them and another for other half

Azanul avatar Oct 14 '22 17:10 Azanul

let's do pages vs components as that sounds a little bit like a more logical difference

/src/pages vs /src/components

that sound good?

colbyfayock avatar Oct 14 '22 17:10 colbyfayock

By vs you mean one PR for pages and one for components right?

Azanul avatar Oct 14 '22 17:10 Azanul

Let me take up components then

Azanul avatar Oct 14 '22 17:10 Azanul

yup, sounds great

colbyfayock avatar Oct 14 '22 17:10 colbyfayock