fitter icon indicating copy to clipboard operation
fitter copied to clipboard

New loguru logging seems not to play nice with Python logging.

Open sarusso opened this issue 1 year ago • 4 comments

Hi,

commit 61d9845 introduced loguru, but it seems to me that right now it's just using Python root logger under the hood, as it might not be properly set up (as mentioned in https://github.com/Delgan/loguru?tab=readme-ov-file#suitable-for-scripts-and-libraries)

The result is that it becomes hard to include Fitter v1.7.0 in other applications that might need to change logleves, use other handlers or just hide its output. In this sense, it was better to use Python's standard logging.

I am not sure what the solution could be, but right now I am forced to monkey-patch Fitter at runtime to be able to take control over its logging.

sarusso avatar Jan 07 '24 00:01 sarusso

dear @sarusso thanks for reporting this issue. indeed, I naively used loguru and I believe this is not really what I wanted. I need to look a bit more at the doc you sent and will probably roll back to previous version.

cokelaer avatar Jan 11 '24 12:01 cokelaer