fitter icon indicating copy to clipboard operation
fitter copied to clipboard

Feature request - Supporting custom (non-scipy) distributions

Open msat59 opened this issue 4 years ago • 1 comments

Hi.

Fitter only supports distributions available in scipy. I need to include a distribution called 'PERT", which is available as an external module. It is not possible to use it in a way Fitter calls the distribution functions; dist = eval("scipy.stats." + distribution).

I recommend adding a new argument, called something like isCustomDist, or you can check when the distribution name is not string. When it is true, the eval() section gets is bypassed.

I can assist to implement it.

msat59 avatar May 31 '21 12:05 msat59

@msat59 I won't have too much time to implement this new feature but if you are willing to add a PR, I'll be more than happy to review/accept it. In any case, I let this open to keep the request in mind. Thanks for your suggestion !

cokelaer avatar Sep 02 '21 19:09 cokelaer