cohere-toolkit icon indicating copy to clipboard operation
cohere-toolkit copied to clipboard

Update bedrock.py

Open billytrend-cohere opened this issue 1 year ago • 1 comments

Thank you for contributing to the Cohere Toolkit!

  • [ ] PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • [ ] PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • [ ] Add tests and docs: Please include testing and documentation for your changes

  • [ ] Lint and test: Run make lint and make run-tests

AI Description

This pull request updates the BedrockDeployment class in bedrock.py by removing hardcoded models from the BedrockClient initialization.

File Changes

  • src/backend/model_deployments/bedrock.py

Code Changes

  • Removes the hardcoded values for chat_model, embed_model, and generate_model from the BedrockClient initialization in the __init__ method of the BedrockDeployment class.

billytrend-cohere avatar Aug 14 '24 16:08 billytrend-cohere

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.10%. Comparing base (f9ec818) to head (637a1f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files         238      238           
  Lines       10455    10455           
=======================================
  Hits         8061     8061           
  Misses       2394     2394           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 14 '24 16:08 codecov-commenter