tabnine-nvim icon indicating copy to clipboard operation
tabnine-nvim copied to clipboard

Handle errors in finding binary path

Open aarondill opened this issue 2 years ago • 5 comments

This avoids constant nil errors (fixes #77), and quits early if the binary can't be found. Notifications can easily be added in future commits if so desired to warn the user about what is wrong.

to @amirbilu and @vendion, should I add these notifications, or is a silent fail preferable? or, should we write to config.log_file_path if it's defined?

aarondill avatar Jun 18 '23 09:06 aarondill

I would vote for either silent fail or logging, as a notification would be annoying as well (although shouldn't negatively affect Neovim's usability). I don't need to be constantly reminded that Tabnine doesn't support all the platforms that I use, and would more than likely make me consider canceling my pro subscription.

vendion avatar Jun 19 '23 19:06 vendion

I would vote for either silent fail or logging, as a notification would be annoying as well (although shouldn't negatively affect Neovim's usability). I don't need to be constantly reminded that Tabnine doesn't support all the platforms that I use, and would more than likely make me consider canceling my pro subscription.

I could understand not wanting a notification on unsupported hardware (though that could be solved in lazy.nvim btw), but should we notify if the binary is not there? that means either the build script failed and needs to be rerun, or else the user (accidentally?) deleted the binary folder w/o rerunning the script.

aarondill avatar Jun 20 '23 17:06 aarondill

guys what's the status here?

amirbilu avatar Jul 12 '23 11:07 amirbilu

We were waiting on your input on the notifications, I believe, but I just added them for missing files, if the arch is in our list of supported ones. So this should now be ready to merge.

aarondill avatar Jul 12 '23 12:07 aarondill

@amirbilu any update on getting a review here?

aarondill avatar Jul 20 '23 23:07 aarondill