DigitalOceanApp icon indicating copy to clipboard operation
DigitalOceanApp copied to clipboard

Published 20 hours ago • verified publisher icon coding-blocks

The Settings button on the home screen isn't functioning.

Open vinayakkgarg opened this issue 7 years ago • 5 comments

screenshot_20180515-201446

vinayakkgarg avatar May 15 '18 14:05 vinayakkgarg

I was able to reproduce this on my device and will see if I can't fix it and submit a PR. I've never worked on this project before but I'd like to help.

4lch4 avatar May 16 '18 22:05 4lch4

I've figured out the cause of the bug, there's no SettingsActivity or Fragment 😅

I'll submit a PR to remove the Settings button until the Activity has been created.

4lch4 avatar May 16 '18 23:05 4lch4

I see it's not going to actually be that easy... I've removed the Settings option but it screws with how they have the Toolbar formatted.

Gonna take me a bit more time to fix it seems.

4lch4 avatar May 16 '18 23:05 4lch4

There we go @vinayakkgarg, I've submitted a PR which fixes the issue. Here's to hoping the maintainers can add it soon. 😄

4lch4 avatar May 17 '18 05:05 4lch4

Hey @championswimmer, this issue can be closed. I'd close it myself but I don't have permissions too.

4lch4 avatar May 17 '18 21:05 4lch4