ddf icon indicating copy to clipboard operation
ddf copied to clipboard

DDF-6704 improve query logging

Open glenhein opened this issue 3 years ago • 3 comments

What does this PR do?

Add detailed logging for the pre and post query plugins, and for the solr query code.

Note: The original intent was to include the trace-id in the solr logging, however there is a problem in the code with the thread context getting passed through to the solr code.

Who is reviewing it?

@jlcsmith @derekwilhelm

Select relevant component teams:

@codice/io @codice/solr

Ask 2 committers to review/merge the PR and tag them here.

@brendan-hofmann @clockard

How should this be tested?

Enable trace logging:

log:set TRACE ddf.catalog.impl.operations log:set TRACE ddf.catalog.source.solr

Perform a query in the UI. Check the DDF log file for the extra logging.

Any background context you want to provide?

What are the relevant tickets?

Fixes: #6704

Screenshots

Checklist:

  • [ ] Documentation Updated
  • [ ] Update / Add Threat Dragon models
  • [ ] Update / Add Unit Tests
  • [ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

glenhein avatar Aug 09 '22 15:08 glenhein

build now

jlcsmith avatar Aug 16 '22 01:08 jlcsmith

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Aug 16 '22 01:08 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Aug 16 '22 03:08 cxddfbot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Oct 15 '22 19:10 stale[bot]