python-test-framework icon indicating copy to clipboard operation
python-test-framework copied to clipboard

handling memory error in timeout utility

Open Blind4Basics opened this issue 4 years ago • 2 comments

  • removed the use of test.expect_no_error inside the timeout utility:

    • done "manually", allowing to handle data passed to the thread
    • consequence: DOCS need an update because there isn't any extra assertion anymore, now.
  • tested on cw with 3.6, 3.8 wihtout imports, 3.8 with imports: work as expected.

  • removed a comment in the framework about the timeout (deprecated info)

  • added the default message for timeout ssertion (https://github.com/codewars/python-test-framework/issues/4)

~~Still need to upddate the tests output (and maybe the tests files)~~ done => trying to pass the outputs checks... XD

Blind4Basics avatar Jun 29 '21 19:06 Blind4Basics

@kazk: the tests are fucking slow to run... I bet this PR will still have troubles about the expected outputs, but if you can already take a look...?

I'll try again to offer the possibility to wrap blocks with the timetout utility while avoiding the assertion outside any test.it block, but that will be for another PR.

Blind4Basics avatar Jun 29 '21 20:06 Blind4Basics

I don't get it... :/

exception isn't raised, apparently, while it's there in the test file. The memory crash is even weirder, because the exact same code is behaving as expected in a kumite... :/

Bed time, now. Cheers

Blind4Basics avatar Jun 29 '21 21:06 Blind4Basics