pyrotech-1.12 icon indicating copy to clipboard operation
pyrotech-1.12 copied to clipboard

Make Bloomery recipe & WitherForgeRecipe public

Open juraj-hrivnak opened this issue 1 year ago • 2 comments
trafficstars

Hello, I understand why these constructors are package-private since you should use the recipe builders. Yet, the reason for making these constructors public is to provide compatibility for the GroovyScript mod to add these recipes using its recipe builders. All the best, teksturepako

juraj-hrivnak avatar Jul 18 '24 17:07 juraj-hrivnak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 18 '24 17:07 CLAassistant

I'm not entirely convinced this is the right solution for the problem. The builders assert certain conditions which are then assumed by the rest of the code. Exposing the constructors directly places the responsibility of those assertions into the user domain, which invalidates the assumptions.

Is there no way to use the provided builders with the GroovyScript mod?

codetaylor avatar Jul 18 '24 19:07 codetaylor