terraform-provider-coder icon indicating copy to clipboard operation
terraform-provider-coder copied to clipboard

feat: add login_type to coder_workspace_owner data source

Open johnstcn opened this issue 1 year ago • 7 comments

...we can expose account type, i.e., password, github, oidc, or none (could be extracted to a new issue) image

Originally posted by @matifali in https://github.com/coder/terraform-provider-coder/issues/219#issuecomment-2135511772

johnstcn avatar May 28 '24 15:05 johnstcn

Hi, is this issue still open? I would like to give it a try.

pmareke avatar Sep 09 '24 15:09 pmareke

Hi, is this issue still open? I would like to give it a try.

Yes, this issue has not yet been worked on!

johnstcn avatar Sep 10 '24 15:09 johnstcn

Great, done!

pmareke avatar Sep 10 '24 15:09 pmareke

Hi @pmareke thank your for your contribution. Could you run make gen to let the linter pass?

matifali avatar Sep 11 '24 11:09 matifali

Hi @pmareke thank your for your contribution. Could you run make gen to let the linter pass?

Done!

pmareke avatar Sep 11 '24 11:09 pmareke

https://github.com/coder/terraform-provider-coder/pull/287 updates the provider to add the field. A separate PR will be required in coder/coder to set CODER_WORKSPACE_OWNER_LOGIN_TYPE.

johnstcn avatar Sep 11 '24 13:09 johnstcn

Thanks so much @johnstcn, I really like doing the PR!

pmareke avatar Sep 11 '24 13:09 pmareke

#287 updates the provider to add the field. A separate PR will be required in coder/coder to set CODER_WORKSPACE_OWNER_LOGIN_TYPE.

@johnstcn do you know if there was a subsequent PR raised for this? Right now the provider just raises a warning each time: Warning: WARNING: The CODER_WORKSPACE_OWNER_LOGIN_TYPE env variable is not set.

dannykopping avatar Nov 13 '24 13:11 dannykopping

Is it merged into release/1.0 branch?

matifali avatar Nov 13 '24 13:11 matifali

@dannykopping @matifali looks like it wasn't. I can add one quickly. Edit: https://github.com/coder/coder/pull/15499 Edit edit: the above PR has been merged to coder/coder#main, we can release the updated provider version closer to when we cut the next release

johnstcn avatar Nov 13 '24 14:11 johnstcn

We will close it in release v2.0

matifali avatar Nov 20 '24 18:11 matifali