code-server icon indicating copy to clipboard operation
code-server copied to clipboard

Fix settings sync login and "loading" text

Open code-asher opened this issue 4 years ago • 14 comments

Currently if you hover over the account login when you aren't logged in it just says "loading".

This is what it should look like instead:

Pressing "turn on settings sync" then takes you through the login process. It allows you to sign in with Microsoft and GitHub although I'm not sure we'll be able to support both or only GitHub.


If you are already logged in (to GitHub) supposedly syncing works and the icon works fine too but we should verify this.


Previous issues: https://github.com/cdr/code-server/issues/2587 https://github.com/cdr/code-server/issues/2913

code-asher avatar May 19 '21 15:05 code-asher

Interestingly if you have the GitHub pull request extension installed the icon works but there is still no sync.

After poking around it seems that settings sync is intentionally not included in the OSS.

So we'll still want to have the "you are not signed in" verbiage when you aren't signed in and there are no extensions providing auth but we won't have the "turn on settings sync" option.

And then at a later date perhaps we can look into implementing sync.

code-asher avatar May 19 '21 16:05 code-asher

After poking around it seems that settings sync is intentionally not included in the OSS. Any particular reason? My VS Code local install shows it here: image

But when I go to the remote container it's missing as you said: image

Just wondering why this would be intentional?

johnsonw avatar Jul 29 '21 05:07 johnsonw

I can make guesses but I don't know for sure why it's not available for OSS builds. Here is the comment from one of the VS Code devs but there is no further explanation: https://github.com/microsoft/vscode/issues/105310#issuecomment-693262654

code-asher avatar Jul 29 '21 18:07 code-asher

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

stale[bot] avatar Feb 07 '22 22:02 stale[bot]

I'm still having this issue.

tsndr avatar Mar 20 '22 03:03 tsndr

Same here...

emielvangoor avatar Mar 23 '22 11:03 emielvangoor

I don't know if this has ever worked with code-server unfortunately 😢

jsjoeio avatar Mar 23 '22 18:03 jsjoeio

Same here...

I use WSL2 Ubuntu. I install git on the WSL Ubuntu from terminal, then the problem solved.

corngk avatar May 15 '22 14:05 corngk

Same here...

I use WSL2 Ubuntu. I install git on the WSL Ubuntu from terminal, then the problem solved.

i'm using Mac OS Monterey. I've moved away from code-server, i never managed to fix this unfortunately.

emielvangoor avatar May 18 '22 07:05 emielvangoor

same issue from chromebook

norbertjoni avatar May 19 '22 11:05 norbertjoni

@jsjoeio It worked for me for ages and suddenly broke (i.e worked in march broke on the 21st June). This issue doesn't seem to cover that context?

Sharpz7 avatar Jun 22 '22 19:06 Sharpz7

@Sharpz7 interesting...it's never worked for me. When you say "cover that context", what are you referring to?

jsjoeio avatar Jun 22 '22 20:06 jsjoeio

Sorry, after more extensive testing it seems that Copilot had a login system change on the same day as this started, so is just a co-incidence. I apoligize ;)

Sharpz7 avatar Jun 22 '22 22:06 Sharpz7

Ahhhh interesting! Thanks for confirming. No worries! 😄

jsjoeio avatar Jun 23 '22 17:06 jsjoeio

how does https://github.dev achive using settings sync?

nmcc1212 avatar Nov 11 '22 09:11 nmcc1212

I assume github.dev is owned by GitHub (Microsoft) in which case settings sync will work for them since they are not using the OSS version of Code.

code-asher avatar Nov 14 '22 19:11 code-asher

if you may have noticed all microsoft extensions are missing in the oss version. thats why i uninstalled it after short testing about a year ago as i'm using a lot of them and setting-sync would be useless if half of my extensions are missing.

there is currently no workaround as long as there is no version like ,,bin-server"

bitdruid avatar Jan 20 '23 12:01 bitdruid

same issue When I pressed "turn on settings sync" ,there is nothing happened... I run code-server with docker, any ideas to help me login?

sunerpy avatar Mar 29 '23 13:03 sunerpy

docker latest So how do we solve this problem

dnslin avatar Apr 30 '23 15:04 dnslin

Any update about this? I am running code-server on Kubernetes.

image

cpatrickalves avatar Jul 31 '23 14:07 cpatrickalves

It looks like upstream changed "loading" to "no accounts requested yet..." so I think we can consider that portion of the issue resolved.

And for the settings sync portion we have another issue tracking that (https://github.com/coder/code-server/issues/2195) so I will close this issue.

code-asher avatar Jul 31 '23 18:07 code-asher