Bill Dengler

Results 135 comments of Bill Dengler

Also, if this PR is merged, I'm really thinking it should be gated behind a feature flag. This is a fundamental change to how terminals work in NVDA. As a...

> I think that some check should be done on the windows terminal version as not all support UIA notifications No, because: * With "undocking", the version number isn't always...

> I've noticed that when it announces new text, everything is spoken as one line @leonardder I've provided a patched notification handler that should work around this (you'll need to...

> 2. Toggling report dynamic content changes off doesn't stop the notifications from reading. This is sometimes useful. Fixed in the suggested change to the UIA notification handler above. As...

* `EnhancedTermTypedCharSupport` subclasses `LiveText`. * `EnhancedTermTypedCharSupport` depends on `event_textChange` for password suppression (in addition to `LiveText` using it to diff). Registering for this event in terminals introduces serious performance problems...

@leonardder Can we find a way not to register for or receive `textChange` events in wt now that we're not using them? This should seriously improve performance.

> Do you have any proof of that statement (i.e. that it improves performance)? In what circumstances? Yes. In particular, when we're flooded with new text: 1. Run the `wtNotifications`...

> Is there a way to retain backwards compatibility by keeping `NVDAObjects.UIA.winConsoleUIA.WinTerminalUIA`? I could make it an alias for the currently default implementation (diff-based for now, then notifications based later),...

CC @valdisvi