No need full URI in request

[r3bers]

trafficstars

There is Full URI in constants. But better be URI without base. https://github.com/codenix-sv/bittrex-api/blob/c4499011e6b2cbd831734f23aa68f79ddfa0e698/tests/Middleware/AuthenticationTest.php#L17

Used here: https://github.com/codenix-sv/bittrex-api/blob/c4499011e6b2cbd831734f23aa68f79ddfa0e698/tests/Middleware/AuthenticationTest.php#L31

And here: https://github.com/codenix-sv/bittrex-api/blob/c4499011e6b2cbd831734f23aa68f79ddfa0e698/tests/Middleware/AuthenticationTest.php#L22

According GuzzleHttp Docs Base URI used on Client Class, and in Request only need URI. I start using BASE_URI in v3 implementation of Authentication Class and catch this error like doubling BASE_URI in PreSign

[codenix-sv]

Hi. Thank you for your feedback!

This improvement will be implemented in the new release.

[r3bers]

I'm made v3 version already. If you wanted, I can return your namespace and pull request all changes. I made mine namespaces just for testing purposes and using both.

https://github.com/r3bers/bittrex-api

On Sun, 12 Jul 2020, 12:35 Volodymyr Svyryd, [email protected] wrote:

Hi. Thank you for your feedback!

This improvement will be implemented in the new release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/codenix-sv/bittrex-api/issues/4#issuecomment-657197566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3NUQ7PZA5LPOODHE5H5OTR3F7U3ANCNFSM4OR56XAA .

[codenix-sv]

Thank you for your proposal, but v3 version is already in development.

[r3bers]

Some tip if you will imply HEAD methods for Sequence and count for Private API to prevent throttling. Bittrex didn't count HEAD in 60 per minute Limit.

[codenix-sv]

Thanks for the tip. I really appreciate your help

[holtkamp]

https://github.com/codenix-sv/bittrex-api/issues/4#issuecomment-660640672

Just wondering, are you still working on this?