codemod icon indicating copy to clipboard operation
codemod copied to clipboard

[studio] Message textarea "Send message" button covers text

Open with-heart opened this issue 1 year ago • 2 comments

Issue Description

Select one of: [ ] Generated codemod is not correct [ ] Bug in Codemod Studio [x] UI/UX improvement request [ ] Feature request

Actual Results

image

Expected Results

image

Technical details

Since the "Send message" button is absolutely positioned, the textarea should have a larger padding-right value to prevent its text content from being covered by the button.

with-heart avatar Jul 23 '24 15:07 with-heart

thanks for paying attention to the details. we will get to this. low pri, low effort.

alexbit-codemod avatar Jul 24 '24 21:07 alexbit-codemod

Is anyone working on this now? If not, I would like to start working on this!

poswalsameer avatar Oct 08 '24 18:10 poswalsameer

@poswalsameer would you like to pick this up if the issue still persists? If not, I can close the issue as stale.

mohab-sameh avatar Dec 26 '24 15:12 mohab-sameh

@poswalsameer would you like to pick this up if the issue still persists? If not, I can close the issue as stale.

Yeah, still can see this issue, will start working on it.

poswalsameer avatar Dec 26 '24 15:12 poswalsameer

Okay awesome! Thanks a lot @poswalsameer. Will stay tuned to this issue so I can feature you in our list of contributors once an issue is pushed.

mohab-sameh avatar Dec 26 '24 17:12 mohab-sameh

Okay awesome! Thanks a lot @poswalsameer. Will stay tuned to this issue so I can feature you in our list of contributors once an issue is pushed.

Yep, also in my previous contribution. I suggested having a local dev setup guide to help the new contributors in setting up this project. Ig I suggested this to @alexbit-codemod. So if possible, please add this so it could be helpful to everyone who's contributing to codemod.

poswalsameer avatar Dec 26 '24 17:12 poswalsameer

we are making some considerable revamp to our platform and will encourage more contribution with better guidelines once v2 is ready. thanks @poswalsameer

alexbit-codemod avatar Dec 26 '24 18:12 alexbit-codemod

Hi @mohab-sameh, I have added the PR along with a screenshot for your reference. It was a one-line fix, so yeah sorted.

poswalsameer avatar Dec 27 '24 17:12 poswalsameer

@poswalsameer Awesome! Closing as completed. @all-contributors add @poswalsameer for bugs

mohab-sameh avatar Dec 30 '24 14:12 mohab-sameh

@mohab-sameh

I've put up a pull request to add @poswalsameer! :tada:

allcontributors[bot] avatar Dec 30 '24 14:12 allcontributors[bot]