coding-standard issues

phpcbf replaces indentation tab in array

5

When I run phpcbf, it replaces indentation tab with 3 spaces in array. command: ```sh-session $ vendor/bin/phpcbf --standard=./vendor/codeigniter4/codeigniter4-standard/CodeIgniter4 --encoding=utf-8 system/Language/en/RESTful.php ``` before: ```php return [ 'notImplemented' => '"{0}" action not...

kenjis

phpcbf breaks /** @var ... */

6

```diff --- a/system/BaseModel.php +++ b/system/BaseModel.php @@ -299,7 +299,9 @@ abstract class BaseModel $this->tempUseSoftDeletes = $this->useSoftDeletes; $this->tempAllowCallbacks = $this->allowCallbacks; - /** @var Validation $validation */ + /** + * @var Validation...

kenjis

Update the README

Paths and links need to change as it's not been updated since moving the project to the codeigniter4 packagist and github namespace. It went from louisl to bcit-ci and is...

louisl

Cannot handle nested nested arrays

1

It seems to me that phpcs/cbf are getting confused with the braced nesting of arrays in some test classes, and giving up. Two examples: I have found a single method...

jim-parry

PHPCBF mis-aligning equals signs

Another example of a suspect configuration inside PHPCBF ... it is inappropriately aligning subesquent assignment statements on the = sign, violating any reasonable line length rule. Example: public function testBasicHandle()...

jim-parry

PHP Docs: int/bool vs integer/boolean

4

Currently the `int` params and returns are being updated to `integer`. Same from `bool` to `boolean`. The following doc (right): ```php /** * @param int $n * * @return int...

natanfelles