dbt-sqlite icon indicating copy to clipboard operation
dbt-sqlite copied to clipboard

Published 20 hours ago • verified publisher icon codeforkjeff

upgrade to support dbt-core v1.2.0

Open dataders opened this issue 3 years ago • 1 comments

We've just published the release cut of dbt-core 1.2.0, dbt-core 1.2.0rc1 (PyPI | GitHub release notes).

https://github.com/dbt-labs/dbt-core/discussions/5468 is an open discussion with more detailed information, and https://github.com/dbt-labs/dbt-core/issues/5474 is for keeping track of the communities progress on releasing 1.2.0

Below is a checklist of work that would enable a successful 1.2.0 release of your adapter.

  • [ ] migrate necessary cross-db macros into adapter and ensure they're tested accordingly
  • [ ] remove any copy-and-pasted materialization (if your adapter inherits from another adapter)
  • [ ] add new basic tests BaseDocsGenerate and BaseDocsGenReferences
  • [ ] consider checking and testing support for Python 3.10

https://github.com/dbt-labs/dbt-core/pull/5432 might make it into the second release cut in the next week, in which case, you'll also might want to:

  • [ ] implement method and tests for connection retry logic

dataders avatar Jul 14 '22 19:07 dataders

Here's a branch with some WIP. Time is scarce for me at the moment, so it may take me a while to work through the failing cross-db macro tests. If anyone wants to help, they're welcome to submit PRs into that branch! 😅

https://github.com/codeforkjeff/dbt-sqlite/pull/24

codeforkjeff avatar Jul 20 '22 00:07 codeforkjeff

Looks like there have been two RC releases. Can a final version of v1.2.0 be tagged?

cboden avatar Jan 08 '23 14:01 cboden

I haven't worked on this in a few months, but I think there's two areas remaining to be done:

  • unimplemented macros:
    • #26
    • #27
    • #28
    • #29
  • get data types to be consistent throughout: https://github.com/codeforkjeff/dbt-sqlite/issues/30

The latest 1.2.0a3 release should be working in a basic way with dbt-core 1.2.x but it'd be good to resolve these before a final release.

Anyone is welcome to help if they have the time, energy, and know-how!

codeforkjeff avatar Jan 11 '23 02:01 codeforkjeff

I think I got a handle on the type issues (see #36).

I may just give up on those macros and do a 1.2.0 release. The date-related ones are of somewhat limited use because date types aren't enforced in SQLite anyway.

codeforkjeff avatar Jan 17 '23 05:01 codeforkjeff