Windows fails to upload coverage if multiple files are specified

[hameerabbasi]

See log lines here.

[thomasrockhu-codecov]

@hameerabbasi I'm off until the new year, I'll look at this when I get back. I think this may be a problem with the way we do globbing

[hameerabbasi]

Copying the log lines here as GH actions logs aren't permanent:

==> Running upload-coverage
      ./codecov.exe  upload-coverage -t <redacted> --git-service github --file ./**/coverage*.xml --gcov-executable gcov
info - 2024-12-19 06:59:58,262 -- ci service found: github-actions
Usage: codecov.exe upload-coverage [OPTIONS]
Try 'codecov.exe upload-coverage -h' for help.

Error: Got unexpected extra arguments (.\coverage_MLIR.xml .\coverage_Numba.xml)

[thomasrockhu-codecov]

@hameerabbasi I'm almost positive this is a glob issue right now. I have an issue slated next month to work on adding proper glob support to the underlying CLI, but I'm afraid for now, the workaround is to do something like

- name: Upload coverage to Codecov
  uses: codecov/codecov-action@v5
  with:
    token: ${{ secrets.CODECOV_TOKEN }}
    files: coverage_MLIR.xml,coverage_Numba.xml

[thomasrockhu-codecov]

@hameerabbasi just a stupid question, what happens if you run it as

files: "./**/coverage*.xml"

[hameerabbasi]

I can try -- but the yaml will parse to the same thing, it won't even contain the quotes.

[thomasrockhu-codecov]

@hameerabbasi ok, do you mind trying again on the latest? (with and without quotes)

[hameerabbasi]

@thomasrockhu-codecov The following diff seemed to do the trick: https://github.com/pydata/sparse/pull/764/commits/148d1aabbc0438fccd8cad6bafce1cf5af4ac18d

However, as one can see, one has to escape the quotes inside the YAML, which could end up being counter-intuitive. Would there be a possibility of adding quotes in the action itself, so that escaped YAML quotes don't need to be provided?