Fail_ci_if_error not actually passing when false

[yarikoptic]

Further details and analysis: https://github.com/dandi/dandi-schema/issues/268#issuecomment-2498414015

but here is what we see

see e.g. in https://github.com/dandi/dandi-schema/actions/runs/12004231865/job/33458888905

and oddly the whole workflow marks that matrix run failed although our config has

https://github.com/dandi/dandi-schema/blob/HEAD/.github/workflows/test.yml#L55

        fail_ci_if_error: false

so there might be two issues ;-)

[thomasrockhu-codecov]

@yarikoptic I believe this should be fixed now. Re the fail_ci_if_error, yeah, this is another bug. However, let me know if you're unblocked now

[yarikoptic]

I still see with v5 (fresh 5.1.1):

[yarikoptic]

• https://github.com/codecov/codecov-action/pull/1721 presumably fixes that issue