codeclimate-eslint icon indicating copy to clipboard operation
codeclimate-eslint copied to clipboard

Add support for plugins for eslint-8 channel

Open rcrenshaw opened this issue 2 years ago • 6 comments

Actual Behavior

It would be helpful to be able to get our GitHub Codeclimate checks to pass. Currently, we are getting errors like this:

Parsing error: Cannot find module 'babel-plugin-macros' Require stack: - /code/babel.config.js

Expected Behavior

Our babel.config.js file uses the following plugins that are not present in the list of Dependencies in the eslint-7 package.json file:

@babel/plugin-macros @babel/preset-typescript @babel/plugin-proposal-optional-chaining @babel/plugin-syntax-dynamic-import @babel/plugin-transform-destructuring @babel/plugin-proposal-class-properties @babel/plugin-proposal-private-methods @babel/plugin-proposal-private-property-in-object @babel/plugin-proposal-object-rest-spread @babel/plugin-transform-regenerator babel-plugin-dynamic-import-node @babel/plugin-transform-runtime

rcrenshaw avatar Apr 26 '23 19:04 rcrenshaw

Hi @rcrenshaw thanks for reaching out about this, just to confirm do you need this change for eslint-8 or for eslint-7? Happy to make the update to both. But wanna prioritize whichever helps y'all out sooner vs later 😄

RubyBrewsday avatar Apr 26 '23 19:04 RubyBrewsday

@RubyBrewsday Sorry, this was meant for 8. Thanks!

rcrenshaw avatar Apr 26 '23 20:04 rcrenshaw

@rcrenshaw no worries 😄 will try and get a fix out for you in the next few business days and will let you know once that is working. In the meantime please feel free to reach out if you are hitting any other snags by emailing us at [email protected].

RubyBrewsday avatar Apr 26 '23 20:04 RubyBrewsday

I see that a pull request was merged. Does that mean the change is in effect currently? I was hoping this would fix the issue we are seeing from the github/codeclimate UI but we are still getting the following error on all our JS files. Thanks! Parsing error: Cannot find module 'babel-plugin-macros' Require stack: - /usr/local/node_modules/@babel/core/lib/config/files/plugins.js - /usr/local/node_modules/@babel/core/lib/config/files/index.js - /usr/local/node_modules/@babel/core/lib/index.js - /usr/local/node_modules/@babel/eslint-parser/lib/worker/babel-core.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/worker/handle-message.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/client.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/index.cjs - /usr/local/node_modules/@eslint/eslintrc/dist/eslintrc.cjs

rcrenshaw avatar Apr 27 '23 14:04 rcrenshaw

@rcrenshaw so we are in the process of deploying the changes and it should rollout sometime by the end of the day. Will be sure to ping you once that's out for everyone. 🤞 that things should clear up for yall in a bit (currently a little under 50% rolled out).

RubyBrewsday avatar Apr 27 '23 17:04 RubyBrewsday

Okie doke @rcrenshaw the change should be live now. Your builds should start working, but if you are still running into issues please let us know and we can look into it a bit more

RubyBrewsday avatar Apr 27 '23 20:04 RubyBrewsday