simplecov_json_formatter icon indicating copy to clipboard operation
simplecov_json_formatter copied to clipboard

Updated Formatter

Open shetty-tejas opened this issue 2 years ago • 10 comments

I was making a Github Actions project for working with SimpleCov. Turns out this being the recommended gem by SimpleCov, didn't have some functionalities I was thinking of adding support for. So added it here in this PR. If you have any thoughts or suggestions do let me know 😄

What's Changed:

  • [x] Minimum Coverage Check for file. If fails, the file name and the percent_covered is collected in errors.
  • [x] Groups now contain more information such as covered_lines, missed_lines and total_lines.
  • [x] Also returns config details like minimum_coverage and minimum_coverage_by_file.
  • [x] Total metrics as default (even when groups are not available).

shetty-tejas avatar May 13 '23 20:05 shetty-tejas

This is what I need 🚀

rslhdyt avatar Oct 24 '23 05:10 rslhdyt

@fede-moya Please review this 🙏

eggplants avatar Mar 08 '24 06:03 eggplants

It seems like this organization needs more maintainers!

pboling avatar Mar 08 '24 12:03 pboling

Hey folks!, I'm sorry. I'll try to review this one over the weekend.

f-moya avatar Mar 08 '24 12:03 f-moya

@fede-moya were you able to review this?

shetty-tejas avatar Mar 12 '24 07:03 shetty-tejas

@fede-moya

image

shetty-tejas avatar Jun 30 '24 20:06 shetty-tejas

Hey, sorry, I'm a little busy at the moment I'll get here ASAP thanks for the reminder @shettytejas

f-moya avatar Jun 30 '24 20:06 f-moya

It would be great if a new release could be created after these changes are merged.

eggplants avatar Jul 27 '24 18:07 eggplants

@fede-moya. Any updates with this one?

shetty-tejas avatar Jul 29 '24 17:07 shetty-tejas

@fede-moya Were you able to check this PR?

shetty-tejas avatar Sep 07 '24 06:09 shetty-tejas

This looks like it would be super useful, would love to see it get merged and released.

jagthedrummer avatar Dec 04 '24 19:12 jagthedrummer

@f-moya Any updates on this one?

shetty-tejas avatar Dec 10 '24 08:12 shetty-tejas

By mistake, I deleted my fork causing this PR to be closed. I'll get this reopened in a week 🤦🏾

shetty-tejas avatar Feb 21 '25 13:02 shetty-tejas