AppRater icon indicating copy to clipboard operation
AppRater copied to clipboard

Added ability to intercept button clicks to let the user add custom code

Open grapescan opened this issue 10 years ago • 10 comments

Implemented improvement https://github.com/codechimp-org/AppRater/issues/48

grapescan avatar Nov 27 '15 08:11 grapescan

A nice addition. Can you add example use in the example application and some documentation in the readme file?

andrew-codechimp avatar Dec 01 '15 11:12 andrew-codechimp

Done

grapescan avatar Dec 02 '15 08:12 grapescan

It doesn't send user to market when using AppRater.showRateDialog(this); or when dialog show after 3 days and 7 launches after this addition.

And the demo isn't working.

Mo7mud avatar Dec 03 '15 13:12 Mo7mud

Thanks for spotting, @EgyptianM I've fixed the demo and added warning that callback code runs in background thread.

grapescan avatar Dec 03 '15 14:12 grapescan

Thanks @grapescan for your quick response. I'll check it out. Have a nice day Regards

Mo7mud avatar Dec 03 '15 15:12 Mo7mud

If I didn't Override onRateClick or onLaterClick it doesn't handle them as default action is sending user to the market.

Can you make the default action is sending user to the market without Overriding?

Mo7mud avatar Dec 03 '15 15:12 Mo7mud

Fixed that.

grapescan avatar Dec 04 '15 12:12 grapescan

Thanks a lot :+1:

Mo7mud avatar Dec 08 '15 07:12 Mo7mud

hi @andrew-codechimp, when are you planning to merge this pull request?

mehrrizwan avatar Jul 25 '17 07:07 mehrrizwan

Other than translations I do not intend to add any other functionality to the library at this time. I simply don't have enough time to thoroughly regression test any new functionality. I suggest you take your own fork and work with that.

andrew-codechimp avatar Jul 25 '17 08:07 andrew-codechimp