monorepo icon indicating copy to clipboard operation
monorepo copied to clipboard

Missing dependency on typescript

Open interfect opened this issue 5 years ago • 2 comments

@codechecks/[email protected] has a dependency on node-ts ^8.0.2. But [email protected] has a peer dependency on typescript >=2.0, and [email protected] (which is what gets installed today) has a peer dependency on typescript >=2.7.

Since the CodeChecks client module is the one that depends on the module with the peer dependency, as I understand it the CodeChecks client module is the one that is responsible for depending on it as a non-peer dependency. There should be a dependency on typescript >=2.7 to satisfy node-ts, and this dependency needs to be bumped if/when node-ts releases a new version that matches ^8.0.2 and bumps its peer dependency version.

Without this dependency, I get this at the end of npm ls:

npm ERR! peer dep missing: typescript@>=2.7, required by [email protected]

interfect avatar Jan 10 '20 03:01 interfect

To reproduce:

npm install --save --dev @codechecks/client
npm ls

interfect avatar Jan 10 '20 03:01 interfect

I don't think that ts-node should be in dependencies, it looks strange for me. ts-node usually is used to run typescript code without transpiling locally. @krzkaczor can you please take a look?

timocov avatar Jan 10 '20 09:01 timocov