daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

Fix : keypress handler for Cmd+K on macOS and Ctrl+K on Windows

Open ankitpanchaal opened this issue 1 year ago • 4 comments

PR Fixes:

  • 1 Ensure the dialog opens with Cmd+K on macOS and Ctrl+K on Windows. This change checks for both metaKey and ctrlKey to provide cross-platform support. Additionally, the keypress handler has been optimized for better readability and maintainability. Mac users press Cmd+K only to open a search.

Resolves #[Issue Number if there]

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I assure there is no similar/duplicate pull request regarding same issue

ankitpanchaal avatar May 15 '24 08:05 ankitpanchaal

This looks good @ankitpanchaal. You can fix the placeholder also. So that it should only show cmd+k for mac users. image

piyushmishra1416 avatar May 15 '24 17:05 piyushmishra1416

Actually, I forgot it. Let me do this.

ankitpanchaal avatar May 15 '24 17:05 ankitpanchaal

can u fix the merge conflicts?

hkirat avatar May 17 '24 17:05 hkirat

Doing sir 🥹

ankitpanchaal avatar May 17 '24 19:05 ankitpanchaal