daily-code icon indicating copy to clipboard operation
daily-code copied to clipboard

bug: scrollableContainerRef not initiallized properly, throws error on start.

Open RohanGeorge23 opened this issue 1 year ago • 4 comments

Describe the bug Initialization of the variable scrollableContainerRef is missing!

To Reproduce Steps to reproduce the behavior:

  1. just clone and run the application
  2. You will see the error image

Expected behavior The application should start normally

Screenshots or GIFs image

Info (please complete the following information):

  • Browser : Chrome
  • Version : 24

Additional context Add any other context about the problem here.

Expected behavior A clear ion of the variable has a typezcable, add screenshots to help explain your problem.

Info (please complete the following information):

  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context Looks like someone had typo

RohanGeorge23 avatar Apr 27 '24 03:04 RohanGeorge23

@hkirat when I tried to run the application, I saw there's a missing initialization

This is how it is : const = useRef<HTMLDivElement>(null);

This is how it is supposed to be : const scrollableContainerRef = useRef<HTMLDivElement>(null);

You can check this under ui/src/SearchDialog.tsx Here's the link for your reference https://github.com/code100x/daily-code/blob/8ce213b69145e6f502dbbd9a623fb4fae38ceb02/packages/ui/src/SearchDialog.tsx#L14

RohanGeorge23 avatar Apr 27 '24 03:04 RohanGeorge23

@hkirat Here's the PR. https://github.com/code100x/daily-code/pull/361

RohanGeorge23 avatar Apr 27 '24 04:04 RohanGeorge23

PR is already present.

CodeWhispererr avatar Apr 27 '24 13:04 CodeWhispererr

My Bad

On Sat, 27 Apr 2024 at 7:25 PM, Syan @.***> wrote:

PR is already present.

— Reply to this email directly, view it on GitHub https://github.com/code100x/daily-code/issues/360#issuecomment-2080718108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODCHJGX24YKLP4L3UOWR23Y7OU4RAVCNFSM6AAAAABG3XX7W6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQG4YTQMJQHA . You are receiving this because you authored the thread.Message ID: @.***>

RohanGeorge23 avatar Apr 27 '24 16:04 RohanGeorge23