daily-code
daily-code copied to clipboard
bug: scrollableContainerRef not initiallized properly, throws error on start.
Describe the bug Initialization of the variable scrollableContainerRef is missing!
To Reproduce Steps to reproduce the behavior:
- just clone and run the application
- You will see the error
Expected behavior The application should start normally
Screenshots or GIFs
Info (please complete the following information):
- Browser : Chrome
- Version : 24
Additional context Add any other context about the problem here.
Expected behavior A clear ion of the variable has a typezcable, add screenshots to help explain your problem.
Info (please complete the following information):
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
Additional context Looks like someone had typo
@hkirat when I tried to run the application, I saw there's a missing initialization
This is how it is : const = useRef<HTMLDivElement>(null);
This is how it is supposed to be : const scrollableContainerRef = useRef<HTMLDivElement>(null);
You can check this under ui/src/SearchDialog.tsx Here's the link for your reference https://github.com/code100x/daily-code/blob/8ce213b69145e6f502dbbd9a623fb4fae38ceb02/packages/ui/src/SearchDialog.tsx#L14
@hkirat Here's the PR. https://github.com/code100x/daily-code/pull/361
PR is already present.
My Bad
On Sat, 27 Apr 2024 at 7:25 PM, Syan @.***> wrote:
PR is already present.
— Reply to this email directly, view it on GitHub https://github.com/code100x/daily-code/issues/360#issuecomment-2080718108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODCHJGX24YKLP4L3UOWR23Y7OU4RAVCNFSM6AAAAABG3XX7W6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQG4YTQMJQHA . You are receiving this because you authored the thread.Message ID: @.***>