cli icon indicating copy to clipboard operation
cli copied to clipboard

build: update Nx 19 & other dependencies

Open vmasek opened this issue 1 year ago • 1 comments
trafficstars

closes #771 closes #776

  • [x] ✅ nx run-many -t build
  • [x] ✅ nx run-many -t lint
  • [x] ✅ nx run-many -t unit-test
  • [ ] ❌ nx run-many -t integration-test
    • [ ] ❌ plugin-eslint nx.integration.test.ts create config from target Nx project and its dependencies
  • [x] ✅ nx release publish --dry-run
  • [ ] 🫤 nx run-many -t e2e

image

vmasek avatar Sep 04 '24 16:09 vmasek

Investigation of failing CI in progress 👀

vmasek avatar Sep 04 '24 17:09 vmasek

Ima run e2e in parallel is not a must have for this pr

BioPhoton avatar Oct 20 '24 18:10 BioPhoton

~I am stuck on e2e failing, not really sure how to proceed. The logs in GH actions do not load but you can download them as zip~

vmasek avatar Nov 26 '24 21:11 vmasek

As there were some issues with ESBuild and replacing some build outputs in dist we decided with @matejchalk to dig deep and replace ESBuild with pure TSC already (as we anyway plan to do it for better error stacks & simpler build).

Most of the codebase is migrated now and we'll be fixing the rest of the issues till the pipeline gets green 🟢 🙏🏻

vmasek avatar Nov 29 '24 18:11 vmasek

@matejchalk @BioPhoton this is ready for review

vmasek avatar Dec 05 '24 18:12 vmasek

Do we really need to touch all imports in the code base to migrate to nx v19?

I would really want to avoid this.

I know it is quite big change but is seems like the best direction we could go. We are dropping a bundler and going for pure TS compilation getting errors more streamlined (accurate) and consistent import behavior.

vmasek avatar Dec 09 '24 13:12 vmasek