jquery-fullscreen-plugin icon indicating copy to clipboard operation
jquery-fullscreen-plugin copied to clipboard

the minified version will create a global variable `d`

Open lpetrov opened this issue 11 years ago • 1 comments

In most cases this should not be a problem, but creating global variables is not a good idea.

The minified version should be scoped by a (function(){ ... })() and only expose the expected/required/public functions/variables, e.g. $.fullScreen.

lpetrov avatar Sep 17 '14 09:09 lpetrov

Yeah, it looks like the supplied minified version (jquery.fullscreen-min.js) has not been updated since its code doesn't match that of the non-minified version. The non-minified version has the correct scoping as you indicate, but the supplied minified version does not.

I manually minified the jquery.fullscreen.js file and ended up with the proper scoping and a minified file.

humancalendar avatar Jan 13 '16 23:01 humancalendar