helm-ssm icon indicating copy to clipboard operation
helm-ssm copied to clipboard

Fix Install-binary.sh

Open romeritoCL opened this issue 3 years ago • 5 comments

Hi! Added a fix for both ARM + Linux users

romeritoCL avatar Nov 16 '21 16:11 romeritoCL

Hi! this should fix both the ARM release URL issue and the --version parameter that is currently ignored.

I've done several tests on the install-binary.sh without paramters (grabs latest) and adding --version 3.1.8 (This also works) For ARM I simply added the possible archs and inversed the order of the grep to have the linux first, since linux-arm is more restrictive. Also tested that my self setting $OS and $ARCH on the file.

This plugin is starting to be used by many people and it's good to have it working as expected 👍

romeritoCL avatar Nov 16 '21 17:11 romeritoCL

@romeritoCL

if [VERSION='latest']; then

This should be fixed like if [ $VERSION = 'latest' ]; then

CrusaderX avatar Nov 18 '21 19:11 CrusaderX

Any updates? today I can't install plugin

sergeylanzman avatar Feb 17 '22 08:02 sergeylanzman

@sergeylanzman just fork the repo and fix the issue or you can use my fork

$ helm plugin add https://github.com/crusaderx/helm-ssm

CrusaderX avatar Feb 17 '22 23:02 CrusaderX

@lolgab @pedrocodacy

Can this get merged? Makes it unusable for CI/CD

markandersontrocme avatar Apr 13 '22 21:04 markandersontrocme