Better pod management

[strzinek]

• Allow to create new pods with port mappings - new kebab control on containers panel
• Show pod owner in listings - under pod name
• Correctly limit container ownership when creating container in existing pod - select owner according to pod and disable owner selection

[garrett]

@garrett as we have limited set of integrations, do we still want to have a tabbed layout?

No, please drop the tabs from this modal dialog. Thanks!

[strzinek]

Tabs removed.

I also added volumes section, but found out that mounts wont get created for pod because of bug in Podman: https://github.com/containers/podman/issues/13548 . I am not able to verify it is fixed in 4.x version as I am on fedora 35 for now.

I would also add a new test for creating pod later on.

[strzinek]

Now it is possible to choose if infra container is created. Also, infra containers are not hidden in pods listings anymore.

I also prepared two new tests, TestApplication.testCreatePodUser and TestApplication.testCreatePodSystem.

[jelly]

I think this is a good PR to look at landing next after the rename PR.

[jelly]

The rename PR landed, can you please rebase this PR?

[jelly]

I've rebased the PR, resolved the conflicts and dropped some of the things which can be a follow up PR.

[marusak]

This breaks pixel tests: https://cockpit-logs.us-east-1.linodeobjects.com/pull-961-20220819-084819-8540cbeb-fedora-35/TestApplication-testRunImageSystem-integration-pixels.png

It causes regression, I did this change a few weeks ago - wrong checkout?

Also needs some new tests

[jelly]

This breaks pixel tests: https://cockpit-logs.us-east-1.linodeobjects.com/pull-961-20220819-084819-8540cbeb-fedora-35/TestApplication-testRunImageSystem-integration-pixels.png

It causes regression, I did this change a few weeks ago - wrong checkout?

Also needs some new tests

Hmm the code was moved around so maybe it doesn't pick up some css changes?

[jelly]

Failing tests on ubuntu-2204 are due to podman not support user mounts on 3.4.4 and requires 4.0.0 so our gui should hide it https://github.com/containers/podman/issues/10379

[jelly]

Issue summary:

• Fedora-coreos/debian-testing testCreatePodUser fails for unknown reasons
• Changed Pixel tests for https://cockpit-logs.us-east-1.linodeobjects.com/pull-961-20220927-091133-81d25dcc-fedora-36/pixeldiff.html#TestApplication-testRunImageSystem-integration-medium Ok, issue here is:
  • Our own scss is not applied, ImageRunModal.scss has CSS included in Volume.jsx and ImageRunModal.scss now, that makes no sense at all.
• Requires a new review

[marusak]

Why Owner label is not on the same row?

Like here for example?

Also found it a bit confusing, that when you create pod and give it ports and volumes, you don't see them in the UI unless you add there container and start it.

[jelly]

Also found it a bit confusing, that when you create pod and give it ports and volumes, you don't see them in the UI unless you add there container and start it.

Agreed, however.... the Ports can be found in infraContainer but for the mounts we need infraContainerDetails and that is only available when the pod is started. We should ask the podman guys to expose the mounts in the containers information to make this work nicely.

[marusak]

Can you please write proper release note with screenshot as well?

[strzinek]

Thanks everyone for pushing things through, I haven't had any time to pursue this myself.

[jelly]

Thanks everyone for pushing things through, I haven't had any time to pursue this myself.

No problem, thanks for the initial PR!