tag-security icon indicating copy to clipboard operation
tag-security copied to clipboard

docs: add Liran Tal to reviewers for supply chain security docs

Open lirantal opened this issue 3 years ago • 2 comments

Signed-off-by: Liran Tal [email protected]

lirantal avatar Jun 26 '22 08:06 lirantal

@lumjjb @achetal01 @sublimino This needs at least two of you to approve since it changes permissions in the repo.

TheFoxAtWork avatar Jun 29 '22 14:06 TheFoxAtWork

There is a current restriction around CODEOWNERS now that it requires the user to have certain permission bits on the repo... Let's work this out - https://github.com/cncf/tag-security/issues/947 (we will discuss this at the next leadership meeting)

lumjjb avatar Jun 29 '22 14:06 lumjjb

We are not adding additional permissions. we've opted for a bot to help provide more granular notifications for this. @PushkarJ 's PR https://github.com/cncf/tag-security/pull/970 fixes this!

lumjjb avatar Aug 20 '22 19:08 lumjjb

@lirantal with #970 now merged, would you be willing to make a one-line change to add your Github handle to this list: https://github.com/cncf/tag-security/blob/main/.github/auto_request_review.yml#L28-L33 ?

This will allow you to get rotated in round robin fashion for any reviews related to supply chain security which I believe was the intent of this PR. Let me know if you have any questions :)

PushkarJ avatar Aug 29 '22 18:08 PushkarJ

Yes will do, thank you @PushkarJ 👍

lirantal avatar Aug 30 '22 20:08 lirantal

PR opened and waiting to merge and then close this one.

lirantal avatar Aug 30 '22 20:08 lirantal