tag-security icon indicating copy to clipboard operation
tag-security copied to clipboard

Containerd Project Security Self-Assessment - Security Pals

Open smallfoot47 opened this issue 1 year ago • 5 comments
trafficstars

Containerd Project Self-Assessment

Nathan Smith Sunny Li Swati Baleri Vivek Radhakrishnan

Created and added first draft for OpenMetrics Project Security Self-Assessment. Please feel free to share your feedback on the security self-assessment.

smallfoot47 avatar Dec 08 '23 03:12 smallfoot47

Deploy Preview for tag-security ready!

Name Link
Latest commit 388a9ef45ece68817abf884c5c887fd15a30b244
Latest deploy log https://app.netlify.com/sites/tag-security/deploys/6679ea18b6c7eb0008d67929
Deploy Preview https://deploy-preview-1202--tag-security.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 08 '23 03:12 netlify[bot]

Hi there! I'm just starting to take a look at this, and I noticed that your pull request name isn't very descriptive.

If you take a look at the Pull Requests page, you'll see that the pile can be a lot easier to navigate if we all use descriptive titles. That'll help reviewers move more quickly, and also it's a great practice to follow when you're doing future work on platforms like GitHub/GitLab/Bitbucket/etc.

Instead of Group 27 self assessment a better alternative might be containerd self-assessment

eddie-knight avatar Dec 08 '23 14:12 eddie-knight

I also noticed the DCO check is failing.

You can look at the checks section of the PR (I believe it should always be below the last comment) and look for a red X highlighting the failed check. In this case, you can click Details for more information about how to get that check passing. Screenshot 2023-12-08 at 8 35 18 AM

eddie-knight avatar Dec 08 '23 16:12 eddie-knight

@SassyQuatch47 Kindly address the pending suggestions. We (maintainers) do not have the permissions to update the PR hence we look forward to your updates. In the event it is not feasible, feel free to extend the permissions to us and we are happy to make the updates on your behalf. Thanks!

ragashreeshekar avatar Jan 30 '24 17:01 ragashreeshekar

@SassyQuatch47 Kindly address the pending suggestions. We (maintainers) do not have the permissions to update the PR hence we look forward to your updates. In the event it is not feasible, feel free to extend the permissions to us and we are happy to make the updates on your behalf. Thanks!

Hi @ragashreeshekar , I apologize for the delay. We have given you permissions to update this PR. If any further issues come up, do let us know and we'd be happy to help!

smallfoot47 avatar Jan 31 '24 20:01 smallfoot47