tag-app-delivery icon indicating copy to clipboard operation
tag-app-delivery copied to clipboard

Bug within website partial "page-meta-links": "Edit this page" doesn't work for pages using symlinks

Open niklasbeinghaus opened this issue 2 years ago • 4 comments
trafficstars

Currently, pages that are using symlinks during buildtime refer to a non-existing file in the git-repository which leads to 404 File not Found errors.

"Edit this Page" link in the top right corner on these pages:

  • https://tag-app-delivery.cncf.io/whitepapers/operator/
  • https://tag-app-delivery.cncf.io/whitepapers/platforms/

In my opinion, we should improve User Experience by either fixing the link or changing it to something more helpful.

niklasbeinghaus avatar Apr 26 '23 22:04 niklasbeinghaus

I'm not a UX-Expert, however I'm also not sure how helpful the link is at all? What do we want to achieve with it? Contributions? If so, wouldn't it be easier to link to contribution guidelines?

https://github.com/cncf/tag-app-delivery/pull/392

niklasbeinghaus avatar Apr 26 '23 22:04 niklasbeinghaus

Thanks for discovering and telling us about this @niklasbeinghaus! I like your suggestions, need to look into how to customize that link.

@cjyabraham do you have ideas?

joshgav avatar Apr 28 '23 19:04 joshgav

Do you want to encourage or discourage people from proposing edits to a live whitepaper? If it's the former, perhaps we include the GH url of the page in its frontmatter and use that for the edit link? If it's the latter, possibly we just hide the edit link when nested in the whitepapers directory?

cjyabraham avatar Apr 29 '23 04:04 cjyabraham

We've heard this is a known bug, but @lianmakesthings can you please take a look? Thanks!

joshgav avatar Oct 16 '23 17:10 joshgav