colton

Results 88 comments of colton

* **#26107** * **#26103** 👈 (View in Graphite) * **#26058** * **#26038** * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

> @PedramNavid the deploy docs revamp action is failing, it had succeeded previously and I ran `yarn build` successfully locally -- anything I might be missing on why the build...

Hi @zyd14 - it looks like there are a couple of _pyright_ errors. Would you be able to take a stab at fixing these? ``` [2024-08-19T22:53:27Z] /workdir/python_modules/libraries/dagster-aws/dagster_aws/ecs/launcher.py: [2024-08-19T22:53:27Z] 412:60: Cannot...

@dehume @neverett , below you can find my feedback for the ETL pipeline tutorial. #### /etl-pipeline-tutorial - I'm of the opinion "ETL pipeline tutorial" should be called "Tutorial" - "Imports...

> Incorporated most of Colton's feedback into the ETL tutorial except holding off on: > > > Agreed with Christian that uv pip install should be a toggle between uv...

I think this is great, and am in favor of inclusion of `pyupgrade` rules. Will wait for approval from at least one other though to ensure consensus.

@LintaoAmons it looks to be `base2`. I've confirmed that this works on my end: ``` { "tanvirtin/monokai.nvim", lazy = false, init = function() local palette = require("monokai").ristretto palette.base2 = '#000000'...

I think this looks great, @dbrtly - thanks! If you could address the pyright and ruff issues, then I believe this is good to merge. pyright: ``` [2024-10-15T19:11:30Z] /workdir/python_modules/dagster/dagster/_generate/download.py: [2024-10-15T19:11:30Z]...

@dbrtly - I wasn't able to make a PR merging into this one, so it's merging into _master_. But my findings are that the `multiple=True` args can be a Tuple...

> Apologies for so many changes. > > Based on my experimental observation, there is no practical difference between these snippets: `dagster project scaffold --name dagster_ Given this PR adds...